Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix typo in README #2067

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 27, 2015

No description provided.

@mscdex mscdex added doc Issues and PRs related to the documentations. benchmark Issues and PRs related to the benchmark subsystem. labels Jun 27, 2015
@mscdex
Copy link
Contributor

mscdex commented Jun 27, 2015

LGTM

@@ -9,7 +9,7 @@ Most of the http benchmarks require [`wrk`][wrk] and [`ab`][ab] (ApacheBench) be
These may be available through your preferred package manager.

If they are not available:
- `wrk` may easily built [from source](https://github.com/wg/wrk) via `make`.
- `wrk` may be easily built [from source](https://github.com/wg/wrk) via `make`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, oops. While you are at it, could you change the source link to be [from source][wrk]? Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, changed and pushed.

@Fishrock123
Copy link
Contributor

LGTM

@Fishrock123
Copy link
Contributor

👍 Just make sure the link works in a markdown viewer if you can. (I'm not used to those.)

Also, maybe it should be "may easily be" instead of "may be easily"? I dunno, I'm tired haha.

@Trott
Copy link
Member Author

Trott commented Jun 27, 2015

I checked the link here: https://github.com/Trott/io.js/blob/benchmark-typo/benchmark/README.md

As for "may easily be built from source via make" vs. "may be easily built from source via make", how about we opt for dropping the "easily" altogether and going with "may be built from source via make"?

@ofrobots
Copy link
Contributor

I also prefer 'may easily be built from source'.

@Trott
Copy link
Member Author

Trott commented Jun 29, 2015

Pushed a change with "easily" moved to the desired location per @Fishrock123 & @ofrobots

Trott added a commit that referenced this pull request Jun 29, 2015
PR-URL: #2067
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@ofrobots
Copy link
Contributor

Thanks. Landed: f52d733.

@ofrobots ofrobots closed this Jun 29, 2015
@rvagg rvagg mentioned this pull request Jun 30, 2015
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
PR-URL: nodejs#2067
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Trott Trott deleted the benchmark-typo branch January 9, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants