test: add test for fsPromises.lchmod #20584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
added
experimental
jasnell
approved these changes
May 8, 2018
shisama
force-pushed
the
test-fs-promises-lchmod
branch
2 times, most recently
from
70ef9c2 to
1d85905
Compare
BridgeAR
approved these changes
May 18, 2018
BridgeAR
added
the
author ready
BridgeAR
removed
the
author ready
|
CI completely failed on this one. |
richardlau
requested changes
May 23, 2018
test/parallel/test-fs-promises.js
Outdated
| await symlink(newPath, newLink); | ||
| await lchmod(newLink, newMode); |
There was a problem hiding this comment.
lchmod is Only available on macOS: https://nodejs.org/dist/latest-v10.x/docs/api/fs.html#fs_fs_lchmod_path_mode_callback
There was a problem hiding this comment.
Fixed it. Thank you for your review.
shisama
force-pushed
the
test-fs-promises-lchmod
branch
from
2f802a0 to
4437388
Compare
richardlau
approved these changes
May 24, 2018
added 3 commits
May 25, 2018 16:11
To increase test coverage for fs/promises, add test for fsPromises.lchmod.
shisama
force-pushed
the
test-fs-promises-lchmod
branch
from
4437388 to
ea2a7c7
Compare
BridgeAR
added
the
author ready
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 30, 2018
To increase test coverage for fs.promises by adding a test for lchmod. PR-URL: nodejs#20584 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in 6558dcb 🎉 |
addaleax
pushed a commit
that referenced
this pull request
May 31, 2018
To increase test coverage for fs.promises by adding a test for lchmod. PR-URL: #20584 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase test coverage for fs/promises,
add test for fsPromises.lchmod.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes