Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: remove compiler detection #205

Closed
wants to merge 1 commit into from
Closed

configure: remove compiler detection #205

wants to merge 1 commit into from

Conversation

seishun
Copy link
Contributor

@seishun seishun commented Dec 23, 2014

The GCC version is no longer relevant since only 4.8 and newer are supported. It's probably safe to assume clang on mac since V8 does so too.

The GCC version is no longer relevant since only 4.8 and newer are
supported. It's probably safe to assume clang on mac since V8 does
so too.
bnoordhuis pushed a commit that referenced this pull request Dec 23, 2014
The GCC version is no longer relevant since only 4.8 and newer are
supported. It's probably safe to assume clang on mac since V8 does
so too.

PR-URL: #205
Reviewed-By: Ben Noordhuis <[email protected]>
@bnoordhuis
Copy link
Member

Cheers Nikolai, landed in 0f3d7e6.

@saper
Copy link

saper commented Mar 9, 2015

I am working on getting sass/node-sass to build on FreeBSD and I'd like to use process.config.variables.clang to figure out if iojs was built on FreeBSD 8 or 9 (with gcc as the default compiler) or FreeBSD 10+ (with clang as the default). This is helpful in figuring out whether I need to ship binary binding that links to GNU libstdc++ or the one that works with clang libc++. More details:  sass/node-sass#733

I think this commit disabled process.config.variables.clang that is available in node 0.10.x and 0.12.x

@jbergstroem
Copy link
Member

@saper I'm agree with @mgreter about binary releases not always being the best solution. A compiler check wouldn't necessary solve your problem since clang just as well can compile against libstdc++. I understand that you mostly care about FreeBSD for your binaries, but it'd still be a 90% solution. So, gunning for a 90% fix, I'd personally choose a different compromise (for instance only supporting FreeBSD 10+, leaving older users to compile their own).

@saper
Copy link

saper commented Mar 9, 2015

No problem, I will use it for node and will keep on guessing for iojs :)

This was referenced Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants