errors: remove dead code #20483
Closed
errors: remove dead code #20483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was never falsy, since an array length can only be an integer.
nodejs-github-bot
added
the
errors
4 tasks
jasnell
approved these changes
May 4, 2018
XadillaX
approved these changes
May 4, 2018
trivikr
approved these changes
May 4, 2018
Leko
approved these changes
May 4, 2018
|
Please +1 if it is OK for you to fast track. |
addaleax
removed
the
fast-track
|
Landed in 8f1ee0b (I don’t think asserts really qualify as “dead code”, btw … I mean, not being triggered is kind of their purpose. 😄) |
addaleax
pushed a commit
that referenced
this pull request
May 6, 2018
This was never falsy, since an array length can only be an integer. PR-URL: #20483 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
This was never falsy, since an array length can only be an integer. PR-URL: #20483 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
This was never falsy, since an array length can only be an integer. PR-URL: #20483 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
This was never falsy, since an array length can only be an integer. PR-URL: #20483 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never falsy, since an array length can only be an integer.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes