Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix next-tick-depth #20461

Closed
wants to merge 2 commits into from
Closed

benchmark: fix next-tick-depth #20461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89c7669
benchmark: fix next-tick-depth
apapirovski May 2, 2018
32490e5
fixup: add next-tick-depth-args fix
apapirovski May 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions benchmark/process/next-tick-depth-args.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,52 +8,53 @@ const bench = common.createBenchmark(main, {
process.maxTickDepth = Infinity;

function main({ n }) {
let counter = n;
function cb4(arg1, arg2, arg3, arg4) {
if (--n) {
if (n % 4 === 0)
if (--counter) {
if (counter % 4 === 0)
process.nextTick(cb4, 3.14, 1024, true, false);
else if (n % 3 === 0)
else if (counter % 3 === 0)
process.nextTick(cb3, 512, true, null);
else if (n % 2 === 0)
else if (counter % 2 === 0)
process.nextTick(cb2, false, 5.1);
else
process.nextTick(cb1, 0);
} else
bench.end(n);
}
function cb3(arg1, arg2, arg3) {
if (--n) {
if (n % 4 === 0)
if (--counter) {
if (counter % 4 === 0)
process.nextTick(cb4, 3.14, 1024, true, false);
else if (n % 3 === 0)
else if (counter % 3 === 0)
process.nextTick(cb3, 512, true, null);
else if (n % 2 === 0)
else if (counter % 2 === 0)
process.nextTick(cb2, false, 5.1);
else
process.nextTick(cb1, 0);
} else
bench.end(n);
}
function cb2(arg1, arg2) {
if (--n) {
if (n % 4 === 0)
if (--counter) {
if (counter % 4 === 0)
process.nextTick(cb4, 3.14, 1024, true, false);
else if (n % 3 === 0)
else if (counter % 3 === 0)
process.nextTick(cb3, 512, true, null);
else if (n % 2 === 0)
else if (counter % 2 === 0)
process.nextTick(cb2, false, 5.1);
else
process.nextTick(cb1, 0);
} else
bench.end(n);
}
function cb1(arg1) {
if (--n) {
if (n % 4 === 0)
if (--counter) {
if (counter % 4 === 0)
process.nextTick(cb4, 3.14, 1024, true, false);
else if (n % 3 === 0)
else if (counter % 3 === 0)
process.nextTick(cb3, 512, true, null);
else if (n % 2 === 0)
else if (counter % 2 === 0)
process.nextTick(cb2, false, 5.1);
else
process.nextTick(cb1, 0);
Expand Down
4 changes: 2 additions & 2 deletions benchmark/process/next-tick-depth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ const bench = common.createBenchmark(main, {
process.maxTickDepth = Infinity;

function main({ n }) {

let counter = n;
bench.start();
process.nextTick(onNextTick);
function onNextTick() {
if (--n)
if (--counter)
process.nextTick(onNextTick);
else
bench.end(n);
Expand Down