Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: doc cleanup #20430

Closed
wants to merge 1 commit into from
Closed

doc: doc cleanup #20430

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Apr 30, 2018 •
edited
Loading

Partial doc cleanup as per
#20421

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels Apr 30, 2018
@mhdawson mhdawson mentioned this pull request Apr 30, 2018
Closed
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 30, 2018
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/637/

@vsemozhetbyt
Copy link
Contributor

(nit: on landing, the commit message title needs to be changed into doc: cleanup doc or maybe doc: cleanup n-api.md.)

@vsemozhetbyt vsemozhetbyt mentioned this pull request Apr 30, 2018
Closed
3 tasks
@mhdawson
Copy link
Member Author

@gabrielf can you review this one.

gabrielschulhof
gabrielschulhof approved these changes May 2, 2018
View reviewed changes
Copy link
Contributor

@gabrielschulhof gabrielschulhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielschulhof
Copy link
Contributor

nit: s/Partical/Partial/ in the commit message.

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 3, 2018
@mhdawson
doc: cleanup n-api.md doc
ab58ab1 
Partial doc cleanup as per
nodejs#20421
@mhdawson
Copy link
Member Author

mhdawson commented May 3, 2018

Fixed up commit comment, previous CI run looked good, will land.

@mhdawson
Copy link
Member Author

mhdawson commented May 3, 2018

Landed as 4740e5d

@mhdawson mhdawson closed this May 3, 2018
mhdawson added a commit that referenced this pull request May 3, 2018
@mhdawson
doc: cleanup n-api.md doc
4740e5d 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@mhdawson @MylesBorins
doc: cleanup n-api.md doc
36d93da 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@mhdawson @MylesBorins
doc: cleanup n-api.md doc
b2d6eb7 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mhdawson mhdawson mentioned this pull request Jul 4, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jul 9, 2018
@mhdawson @MylesBorins
doc: cleanup n-api.md doc
6eec3fc 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 10, 2018
@mhdawson @MylesBorins
doc: cleanup n-api.md doc
f4b9985 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@mhdawson @rvagg
doc: cleanup n-api.md doc
4709734 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mhdawson mhdawson deleted the napi-doc100 branch September 30, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mhdawson @vsemozhetbyt @gabrielschulhof @jasnell @cjihrig @trivikr @MylesBorins @nodejs-github-bot