Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove obsolete TODO comments for fs.read #2032

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 22, 2015

Not using test_ca.pem in these files anymore.
Using elipses.txt which has multibyte chars.
Not clear what constitutes "large" but that
can be a different ticket if elipses.txt etc.
are insufficiently large.

Not using test_ca.pem in these files anymore.
Using elipses.txt which has multibyte chars.
Not clear what constitutes "large" but that
can be a different ticket if elipses.txt etc.
are insufficiently large.
@Trott Trott added test Issues and PRs related to the tests. fs Issues and PRs related to the fs subsystem / file system. labels Jun 22, 2015
@Trott Trott changed the title test: remove obsolete TODO comments test: remove obsolete TODO comments for fs.read Jun 22, 2015
@trevnorris
Copy link
Contributor

LGTM

1 similar comment
@jbergstroem
Copy link
Member

LGTM

Trott added a commit that referenced this pull request Jun 23, 2015
Not using test_ca.pem in these files anymore.
Using elipses.txt which has multibyte chars.
Not clear what constitutes "large" but that
can be a different ticket if elipses.txt etc.
are insufficiently large.

PR-URL: #2032
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 23, 2015

Merged in bdfeb79

@Trott Trott closed this Jun 23, 2015
@rvagg rvagg mentioned this pull request Jun 30, 2015
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
Not using test_ca.pem in these files anymore.
Using elipses.txt which has multibyte chars.
Not clear what constitutes "large" but that
can be a different ticket if elipses.txt etc.
are insufficiently large.

PR-URL: nodejs#2032
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@Trott Trott deleted the readstream branch January 9, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants