-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add log output to crashes #20295
Conversation
This comment has been minimized.
This comment has been minimized.
tools/test.py
Outdated
@@ -299,7 +299,7 @@ def HasRun(self, output): | |||
if output.HasCrashed(): | |||
self.severity = 'crashed' | |||
exit_code = output.output.exit_code | |||
self.traceback = "oh no!\nexit code: " + PrintCrashed(exit_code) | |||
self.traceback += "oh no!\nexit code: " + PrintCrashed(exit_code) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO best solution is to drop this whole line and the prev line.
- L290 will set the exit code (it's new code)
- L300 will indicate crash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree because the exit code would not be visible in that case anymore. You are right.
Comment addressed. |
CI has only known flakes :) @refack Does this LGTY? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Landed in a4b4854 |
PR-URL: #20295 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #20295 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #20295 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
@nodejs/build PTAL
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes