Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: create per-isolate strings after platform setup #20175

Closed
wants to merge 1 commit into from
Closed

src: create per-isolate strings after platform setup #20175

wants to merge 1 commit into from

Conversation

ulan
Copy link
Contributor

@ulan ulan commented Apr 20, 2018

Allocation of strings may cause a garbage collection that uses
the platform to post tasks.

Fixes: #20171

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 20, 2018
@addaleax addaleax added the v8 engine Issues and PRs related to the V8 dependency. label Apr 20, 2018
TimothyGu
TimothyGu approved these changes Apr 20, 2018
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The commit message should be changed to conform to our convention though: "src: create strings after platform setup"

bnoordhuis
bnoordhuis approved these changes Apr 21, 2018
View reviewed changes
src/env.cc Outdated
v8::NewStringType::kInternalized, \
sizeof(StringValue) - 1).ToLocalChecked());
PER_ISOLATE_STRING_PROPERTIES(V)
#undef V
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you not indent the preprocessor directives?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@BridgeAR BridgeAR changed the title [src] create per-isolate strings after the platform is set up. src: create per-isolate strings after the platform is set up Apr 23, 2018
@ulan
src: create per-isolate strings after platform setup
c2447f0 
Allocation of strings may cause a garbage collection that uses
the platform to post tasks.

Fixes: #20171
@ulan ulan changed the title src: create per-isolate strings after the platform is set up src: create per-isolate strings after platform setup Apr 23, 2018
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/14445/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 26, 2018
@ulan @BridgeAR
src: create per-isolate strings after platform setup
8c12e01 
Allocation of strings may cause a garbage collection that uses
the platform to post tasks.

PR-URL: nodejs#20175
Fixes: nodejs#20171
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@BridgeAR
Copy link
Member

Landed in 8c12e01 🎉

@BridgeAR BridgeAR closed this Apr 26, 2018
@ulan
Copy link
Contributor Author

ulan commented Apr 26, 2018

Thanks for landing!

MylesBorins pushed a commit that referenced this pull request May 4, 2018
@ulan @MylesBorins
src: create per-isolate strings after platform setup
81de533 
Allocation of strings may cause a garbage collection that uses
the platform to post tasks.

PR-URL: #20175
Fixes: #20171
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
addaleax pushed a commit that referenced this pull request Jun 29, 2018
@ulan @addaleax
src: create per-isolate strings after platform setup
c06a41e 
Allocation of strings may cause a garbage collection that uses
the platform to post tasks.

PR-URL: #20175
Fixes: #20171
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@ulan @rvagg
src: create per-isolate strings after platform setup
e17f05a 
Allocation of strings may cause a garbage collection that uses
the platform to post tasks.

PR-URL: #20175
Fixes: #20171
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hashseed hashseed hashseed approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node::IsolateData allocates V8 objects before initializing platform