Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: confirm symlink #2014

Closed
wants to merge 1 commit into from
Closed

test: confirm symlink #2014

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 19, 2015

Compare mtime returned by lstat() to that from stat(). Former should be mtime of the symlink created by the test, while the latter is the mtime of the file it points to that existed before the test was run.

Using mtime instead of ctime because ctime is different things on different operating systems and this test will fail on some of them when using ctime.

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/53/

This PR addresses a todo comment in the code.

@Trott Trott added test Issues and PRs related to the tests. fs Issues and PRs related to the fs subsystem / file system. labels Jun 19, 2015
@rvagg
Copy link
Member

rvagg commented Jun 19, 2015

lgtm

@bnoordhuis
Copy link
Member

LGTM

Trott added a commit that referenced this pull request Jun 20, 2015
PR-URL: #2014
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 20, 2015

Merged in b0990ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants