http: added aborted property to request #20094

ronag · 2018-04-17T09:59:38Z

Added an aborted property to the request object. Currently, it is not possible to query whether a close event was emitted due to client side socket close without also listening to aborted.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

lpinca · 2018-04-17T10:36:51Z

Two notes:

Please add a test.
Do we really need this? This is to avoid adding a listener for the 'aborted' event right? What's wrong with it?

ronag · 2018-04-17T10:49:58Z

Do we really need this? This is to avoid adding a listener for the 'aborted' event right? What's wrong with it?

Yes, this basically makes aborted superfluous for http/1 (not for http/2 compat). It's a nice to have.

mscdex · 2018-04-17T13:37:25Z

I'm not sure it's worth the overhead of the Date.now() call. Why is it not simply always a boolean, like it's initialized to?

ronag · 2018-04-17T13:47:20Z

@mscdex: Just following how http.ClientRequest does it.

ronag · 2018-04-17T13:49:27Z

https://github.com/nodejs/node/blob/master/lib/_http_client.js#L285

richardlau · 2018-04-17T15:06:39Z

doc/api/http.md

@@ -1288,6 +1288,14 @@ the server, then sockets are destroyed when they time out. If a handler is
 assigned to the request, the response, or the server's `'timeout'` events,
 timed out sockets must be handled explicitly.

+### response.aborted
+<!-- YAML
+added: v10.0.0


This should be added: REPLACEME. The actual version will then be substituted by the releaser when the change first lands in a release.

ronag · 2018-04-17T15:38:18Z

Related: 8ad8157

Trott · 2018-04-17T17:43:56Z

@nodejs/http

mscdex · 2018-04-22T04:46:29Z

Just following how http.ClientRequest does it.

IMHO that could/should be changed to a boolean as well.

BridgeAR · 2018-04-23T07:43:46Z

@ronag is there anything I can help, so it is easier for you to add a test as well? Without a test this PR can not land. Since this has come up in a couple PRs you opened, it would be great to know if there is anything preventing you from writing tests / if there is anything that would help you further.

ronag · 2018-04-23T10:16:24Z

@BridgeAR It takes several minutes to run the tests using the command ./configure && make -j4 test mentioned in the PR guide. Unless I can run a single test in seconds I just don't have the time and I have no idea how to do that.

richardlau · 2018-04-23T10:21:05Z

Unless I can run a single test in seconds I just don't have the time and I have no idea how to do that.

https://github.com/nodejs/node/blob/2060787d386099ceadbb6de2d81dc2f34c90503d/doc/guides/contributing/pull-requests.md#step-6-test

ronag · 2018-04-23T10:25:43Z

@richardlau: yep, following those instructions, it takes 10 minutes to run.

I can do:

out/Release/node test/parallel/my-test.js

But I still need to rebuild the entire thing as soon as I change anything in lib. Which again takes minutes.

I would like to be able to do something like:

nodemon test/parallel/my-test.js

Which will auto run whenever I change anything in lib or test.

BridgeAR · 2018-04-23T11:58:26Z

@ronag

But I still need to rebuild the entire thing as soon as I change anything in lib. Which again takes minutes.

You can run a single test or multiple ones with python tools/test.py -J --mode=release parallel/test-stream2-*. The star indicates a wildcard.

When changing a test you do not have to rebuild the executable. When changing any src or lib files it is necessary to rebuild as with any other regular program.

Doing a minor change after having a up to date build should not take long though. Only the touched files are going to be rebuild and that does not take long (on my machine a couple seconds).
So it is mainly about rebuilding once when starting your PR.

Unless I can run a single test in seconds I just don't have the time

I hope my hints help you already to reduce that overhead. We all have limited time and most collaborators also work on Node.js in their spare time. So we all must go through the same procedure.

ronag · 2018-04-23T13:37:01Z

@BridgeAR ah, I shouldn't do ./configure && make but just make (Sorry, I'm from the Visual Studio world). Maybe update the guidelines with something like:

Workflow:

make -j8
python tools/test.py -J --mode=release parallel/test-stream2-*

ronag · 2018-04-23T15:51:00Z

@mscdex @lpinca @BridgeAR with tests.

Notable Changes: * console: - make console.table() use colored inspect (TSUYUSATO Kitsune) #20510 * fs: - move fs/promises to fs.promises (cjihrig) #20504 * http: - added aborted property to request (Robert Nagy) #20094 * n-api: - initialize a module via a special symbol (Gabriel Schulhof) #20161 * src: - add public API to expose the main V8 Platform (Allen Yonghuang Wang) #20447 PR-URL: #20606

PR-URL: nodejs#20094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Backport-PR-URL: #22850 PR-URL: #20094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Notable changes: * **assert**: - backport some assert commits (Ruben Bridgewater) [#23223](#23223) * **deps**: - V8: cherry-pick 64-bit hash seed commits (Yang Guo) [#23274](#23274) * **http**: - added aborted property to request (Robert Nagy) [#20094](#20094) * **http2**: - backport http2 changes from 10.x (Kelvin Jin) [#22850](#22850) PR-URL: #23974

Notable changes: * **assert**: - backport some assert commits (Ruben Bridgewater) [#23223](#23223) * **deps**: - upgrade to libuv 1.23.2 (cjihrig) [#23336](#23336) - V8: cherry-pick 64-bit hash seed commits (Yang Guo) [#23274](#23274) * **http**: - added aborted property to request (Robert Nagy) [#20094](#20094) * **http2**: - graduate from experimental (James M Snell) [#22466](#22466) PR-URL: #23974

Notable changes: * **assert**: - backport some assert commits (Ruben Bridgewater) [nodejs#23223](nodejs#23223) * **deps**: - upgrade to libuv 1.23.2 (cjihrig) [nodejs#23336](nodejs#23336) - V8: cherry-pick 64-bit hash seed commits (Yang Guo) [nodejs#23274](nodejs#23274) * **http**: - added aborted property to request (Robert Nagy) [nodejs#20094](nodejs#20094) * **http2**: - graduate from experimental (James M Snell) [nodejs#22466](nodejs#22466) PR-URL: nodejs#23974

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Apr 17, 2018

lpinca added http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Apr 17, 2018

richardlau reviewed Apr 17, 2018

View reviewed changes

ronag force-pushed the http-aborted-req branch 2 times, most recently from 50fe188 to 4c3fe2d Compare April 17, 2018 15:18

ronag force-pushed the http-aborted-req branch 3 times, most recently from 8369a98 to 32ee7d5 Compare April 17, 2018 15:41

ronag force-pushed the http-aborted-req branch from 32ee7d5 to 83128a3 Compare April 23, 2018 01:33

ronag force-pushed the http-aborted-req branch 3 times, most recently from 314d6fd to 9ffe99b Compare April 23, 2018 10:37

ronag force-pushed the http-aborted-req branch from 9ffe99b to 0f88ac8 Compare April 23, 2018 15:50

antongolub mentioned this pull request May 17, 2018

Looks to be broken on latest Node.js (10.1.0) antongolub/reqresnext#7

Closed

kjin pushed a commit to kjin/node that referenced this pull request Aug 23, 2018

http: added aborted property to request

5d8ab11

PR-URL: nodejs#20094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

kjin pushed a commit to kjin/node that referenced this pull request Sep 11, 2018

http: added aborted property to request

f82788b

PR-URL: nodejs#20094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

kjin pushed a commit to kjin/node that referenced this pull request Sep 19, 2018

http: added aborted property to request

425879b

PR-URL: nodejs#20094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

MylesBorins mentioned this pull request Sep 26, 2018

[8.x] Backport http2 changes from 10.x #22850

Closed

4 tasks

kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018

http: added aborted property to request

df3e6d9

PR-URL: nodejs#20094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

BethGriggs pushed a commit that referenced this pull request Oct 17, 2018

http: added aborted property to request

1edd7f6

Backport-PR-URL: #22850 PR-URL: #20094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

BethGriggs mentioned this pull request Oct 30, 2018

v8.13.0 proposal #23974

Merged

beevelop mentioned this pull request Nov 20, 2018

2018-11-20 Version 8.13.0 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#250

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http: added aborted property to request #20094

http: added aborted property to request #20094

ronag commented Apr 17, 2018 •

edited

Loading

lpinca commented Apr 17, 2018

ronag commented Apr 17, 2018 •

edited

Loading

mscdex commented Apr 17, 2018

ronag commented Apr 17, 2018 •

edited

Loading

ronag commented Apr 17, 2018

richardlau Apr 17, 2018

ronag commented Apr 17, 2018

Trott commented Apr 17, 2018

mscdex commented Apr 22, 2018 •

edited

Loading

BridgeAR commented Apr 23, 2018

ronag commented Apr 23, 2018

richardlau commented Apr 23, 2018

ronag commented Apr 23, 2018 •

edited

Loading

BridgeAR commented Apr 23, 2018

ronag commented Apr 23, 2018 •

edited

Loading

ronag commented Apr 23, 2018

http: added aborted property to request #20094

http: added aborted property to request #20094

Conversation

ronag commented Apr 17, 2018 • edited Loading

Checklist

lpinca commented Apr 17, 2018

ronag commented Apr 17, 2018 • edited Loading

mscdex commented Apr 17, 2018

ronag commented Apr 17, 2018 • edited Loading

ronag commented Apr 17, 2018

richardlau Apr 17, 2018

Choose a reason for hiding this comment

ronag commented Apr 17, 2018

Trott commented Apr 17, 2018

mscdex commented Apr 22, 2018 • edited Loading

BridgeAR commented Apr 23, 2018

ronag commented Apr 23, 2018

richardlau commented Apr 23, 2018

ronag commented Apr 23, 2018 • edited Loading

BridgeAR commented Apr 23, 2018

ronag commented Apr 23, 2018 • edited Loading

ronag commented Apr 23, 2018

ronag commented Apr 17, 2018 •

edited

Loading

ronag commented Apr 17, 2018 •

edited

Loading

ronag commented Apr 17, 2018 •

edited

Loading

mscdex commented Apr 22, 2018 •

edited

Loading

ronag commented Apr 23, 2018 •

edited

Loading

ronag commented Apr 23, 2018 •

edited

Loading