Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix suspicious heading emphasis in n-api.md #20086

Closed
wants to merge 1 commit into from
Closed

doc: fix suspicious heading emphasis in n-api.md #20086

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

I do not know C++ and N-API domain, so I am not sure what these cases are: some accidental artifacts, intentional markdown emphasis for just these two headings or some not escaped C++ syntax. But rather than creating an issue to ask, I've decided to make a PR so that we can close it if these are not typos.

To check the rendering: napi_open_callback_scope, napi_close_callback_scope.

cc @nodejs/n-api

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 16, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels Apr 16, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 16, 2018

Please, add 👍 here to approve fast-tracking.

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to fast-track

@vsemozhetbyt
Copy link
Contributor Author

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2018
@Trott
Copy link
Member

Trott commented Apr 17, 2018

+1 to fast-tracking

@vsemozhetbyt
Copy link
Contributor Author

Landed in 7dd6d86

@vsemozhetbyt vsemozhetbyt deleted the doc-napi-em branch April 17, 2018 01:53
vsemozhetbyt added a commit that referenced this pull request Apr 17, 2018
PR-URL: #20086
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Kyle Farnung <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 17, 2018
PR-URL: #20086
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Kyle Farnung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants