src: rename ERR_STRING_TOO_LARGE to ERR_STRING_TOO_LONG #19864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old error name and message were trying to be consistent with ERR_BUFFER_TOO_LARGE but they were not really accurate. The kStringMaxLength was measured in number of characters, not number of bytes. The name ERR_STRING_TOO_LARGE also seems a bit awkward. This patch tries to correct them before they get released to users.
nodejs-github-bot
added
buffer
|
CI: https://ci.nodejs.org/job/node-test-pull-request/14117/ cc @jasnell @addaleax @devsnek who previously signed off #19739 |
targos
approved these changes
Apr 7, 2018
BridgeAR
approved these changes
Apr 7, 2018
addaleax
approved these changes
Apr 7, 2018
devsnek
approved these changes
Apr 7, 2018
cjihrig
approved these changes
Apr 7, 2018
|
Another try...: https://ci.nodejs.org/job/node-test-pull-request/14124/ |
BridgeAR
added
author ready
TimothyGu
approved these changes
Apr 8, 2018
| <a id="ERR_STRING_TOO_LARGE"></a> | ||
| ### ERR_STRING_TOO_LARGE | ||
| <a id="ERR_STRING_TOO_LONG"></a> | ||
| ### ERR_STRING_TOO_LONG | ||
|
|
||
| An attempt has been made to create a string larger than the maximum allowed | ||
| size. |
There was a problem hiding this comment.
“longer than the maximum allowed length”?
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 9, 2018
The old error name and message were trying to be consistent with ERR_BUFFER_TOO_LARGE but they were not really accurate. The kStringMaxLength was measured in number of characters, not number of bytes. The name ERR_STRING_TOO_LARGE also seems a bit awkward. This patch tries to correct them before they get released to users. PR-URL: nodejs#19864 Refs: nodejs#19739 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
|
Landed in 3626944 🎉 While landing I also added the suggestion from @TimothyGu |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old error name and message were trying to be consistent with
ERR_BUFFER_TOO_LARGE but they were not really accurate.
The kStringMaxLength was measured in number of characters,
not number of bytes. The name ERR_STRING_TOO_LARGE also
seems a bit awkward. This patch tries to correct them before
they get released to users.
Refs: #19739
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes