doc: clarify child_process.exec promise rejection on non-zero exit #19541
Conversation
Promisify section of child_process.exec doc changed to make clear that non-zero exit codes will result in promise rejection. fixes: nodejs#19494
nodejs-github-bot
added
child_process
|
Thank you! We have the similar warning for the |
vsemozhetbyt
added
promises
Promisify section of child_process.execFile doc changed to make clear that non-zero exit codes will result in promise rejection. fixes: nodejs#19494
|
@vsemozhetbyt Good catch; added. |
|
@TomCoded I'll elaborate on our process a little. This PR will remain open for 72 hours so collaborators and other people have time to review it. If after 72 hours it received no objections from a collaborator (there is a list in https://github.com/nodejs/node ) then we will land it :) Thanks for your contribution - if you want to tackle more issues feel free to let me know and I'll help you find some more changes you're comfortable making :) |
|
@benjamingr It seems we can even fast-track this tiny doc change as per our new policy and not wait for 48/72 hours) |
|
Linting error is not related, see #19438 (comment) |
vsemozhetbyt
added
the
author ready
|
@vsemozhetbyt ah, very nice, I didn't realize we fast-track first contributions now :) |
Promisify sections of `child_process.exec()` and `child_process.execFile()` changed to make clear that non-zero exit codes will result in promise rejection. PR-URL: #19541 Fixes: #19494 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
tniessen
removed
the
author ready
Promisify sections of `child_process.exec()` and `child_process.execFile()` changed to make clear that non-zero exit codes will result in promise rejection. PR-URL: #19541 Fixes: #19494 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
Promisify section of child_process.exec doc changed to make clear
that non-zero exit codes will result in promise rejection.
fixes: #19494
Checklist