Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove custom error message #19526

Closed
wants to merge 1 commit into from
Closed

test: remove custom error message #19526

wants to merge 1 commit into from

Conversation

DingDean
Copy link
Contributor

Default error message contains the actual and expected values,
which is more informative than the custom error message to be deleted.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Affected core subsystem(s)

test

@DingDean
test: remove custom error message
de8c717 
Default error message contains the actual and expected values,
which is more informative than the custom error message to be deleted.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 22, 2018
@Trott
Copy link
Member

Trott commented Mar 22, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13818/

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2018
@trivikr trivikr added the fs Issues and PRs related to the fs subsystem / file system. label Mar 22, 2018
@Trott
Copy link
Member

Trott commented Mar 23, 2018

Ci failures are unrelated build issues.

Linux CI re-run: https://ci.nodejs.org/job/node-test-commit-linux/17292/

ARM fanned CI re-run: https://ci.nodejs.org/job/node-test-commit-arm-fanned/15341/

@tniessen
Copy link
Member

Landed in 85a3d82, thank you! 🎉

@tniessen tniessen closed this Mar 25, 2018
tniessen pushed a commit that referenced this pull request Mar 25, 2018
@DingDean @tniessen
test: remove custom error message
85a3d82 
Default error message contains the actual and expected values,
which is more informative than the custom error message to be deleted.

PR-URL: #19526
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@DingDean
Copy link
Contributor Author

DingDean commented Mar 25, 2018 •
edited
Loading

Thank you! It feels good to start contributing to NodeJS!

targos pushed a commit that referenced this pull request Mar 27, 2018
@DingDean @targos
test: remove custom error message
c1a327b 
Default error message contains the actual and expected values,
which is more informative than the custom error message to be deleted.

PR-URL: #19526
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Leko Leko Leko approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@DingDean @Trott @tniessen @jasnell @Leko @cjihrig @richardlau @lpinca @trivikr @nodejs-github-bot