Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-http2-ping-flood #19395

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 16, 2018

The test is unreliable on some Windows platforms in its current form.
Make it more robust by using setInterval() to repeat the flooding
until an error is triggered.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 16, 2018
@Trott
Copy link
Member Author

Trott commented Mar 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13707/

If this works, this may be the first green CI in a loooooong time....

@Trott
Copy link
Member Author

Trott commented Mar 16, 2018

Three CI failures, all unrelated. Windows is green for the first time in probably weeks or more!

Trying CI again: https://ci.nodejs.org/job/node-test-pull-request/13708/

@Trott
Copy link
Member Author

Trott commented Mar 16, 2018

Ci is green. Like, not yellow. Green. Honest green. Let's land this, shall we?

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 16, 2018
message:
'Flooding was detected in this HTTP/2 session, and it must be closed'
}));
session.on('error', (e) => {
Copy link
Member

@richardlau richardlau Mar 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep common.expectsError and have a second session.on('error', ... for clearInterval?

Edit: not blocking (let's get that CI green), I just find common.expectsError clearer.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 17, 2018
Trott added a commit to Trott/io.js that referenced this pull request Mar 19, 2018
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

PR-URL: nodejs#19395
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Mar 19, 2018

Landed in 0fb017d

@Trott Trott closed this Mar 19, 2018
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

PR-URL: #19395
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

PR-URL: #19395
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 20, 2018
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2018
BethGriggs pushed a commit that referenced this pull request Oct 26, 2018
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

PR-URL: #19395
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
@Trott Trott deleted the fix-http2-ping-flood branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants