assert: fix deepEqual regression #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change of Object.keys in ES6 breaks assert.deepEqual about primitive values. V8: https://code.google.com/p/v8/issues/detail?id=3443 Previously deepEqual depends on Object.key that throws an error for a primitive value, but now Object.key does not throw.
bnoordhuis
pushed a commit
that referenced
this pull request
Dec 22, 2014
Change of Object.keys in ES6 breaks assert.deepEqual about primitive values. V8: https://code.google.com/p/v8/issues/detail?id=3443 Previously deepEqual depends on Object.key that throws an error for a primitive value, but now Object.key does not throw. PR-URL: #193 Reviewed-By: Ben Noordhuis <[email protected]>
|
Thanks, landed in 00a7456. Just a nit: could you sign your patches with your real name next time? Thanks! |
|
thanks! |
jasongin
pushed a commit
to jasongin/nodejs
that referenced
this pull request
Mar 23, 2017
* Convert all locals and parameter names to snake_case Standardize some parameter names across the N-API surface such as ```napi_env env``` and ```size_t length```. Make all the parameter names in the header match the cc file and expand some parameter names from single characters into meaningful words. Also addresses a couple of minor PR feedback items: - Rename ```napi_reference_addref``` and ```napi_reference_release``` to ```napi_reference_ref``` and ```napi_reference_unref``` (respectively) - Rename ```Reference::AddRef``` and ```Reference::Release``` to ```Reference::Ref``` and ```Reference::Unref``` (respectively) - Remove ```napi_create_boolean```, ```napi_get_true```, and ```napi_get_false``` and replace them with ```napi_get_boolean``` - Rename ```napi_get_type_of_value``` to ```napi_typeof``` - Add a ```result_data``` out parameter to ```napi_create_buffer_copy``` which returns the data pointer of the new buffer - Change ```napi_get_value_string_utf8``` and ```napi_get_value_string_utf16``` to accept a null output buffer and return the length of the source string in that case via the ```result``` parameter - Remove ```napi_get_value_string_utf8_length``` and ```napi_get_value_string_utf16_length``` due to the above - Change ```Reference``` ctor and dtor to be protected and added public ```static Reference* Reference::New``` and ```static void Reference::Delete``` methods to make it more clear how the ```Reference``` objects are allocated and cleaned-up - Add a type check to ``napi_get_array_length``` which returns an error if the argument is not an array object - Change ```napi_create_symbol``` to take a ```napi_value``` instead of a ```const char*``` for the symbol description string. The API now throws if description is not a string but NULL is allowed. * Remove UTF-8 BOM characters and other non-ANSI whitespace * Change parameter names for create string APIs and address other feedback * Fixes for unit tests * Fix lint errors found via CI
boingoing
added a commit
to boingoing/node
that referenced
this pull request
Apr 6, 2017
* Convert all locals and parameter names to snake_case Standardize some parameter names across the N-API surface such as ```napi_env env``` and ```size_t length```. Make all the parameter names in the header match the cc file and expand some parameter names from single characters into meaningful words. Also addresses a couple of minor PR feedback items: - Rename ```napi_reference_addref``` and ```napi_reference_release``` to ```napi_reference_ref``` and ```napi_reference_unref``` (respectively) - Rename ```Reference::AddRef``` and ```Reference::Release``` to ```Reference::Ref``` and ```Reference::Unref``` (respectively) - Remove ```napi_create_boolean```, ```napi_get_true```, and ```napi_get_false``` and replace them with ```napi_get_boolean``` - Rename ```napi_get_type_of_value``` to ```napi_typeof``` - Add a ```result_data``` out parameter to ```napi_create_buffer_copy``` which returns the data pointer of the new buffer - Change ```napi_get_value_string_utf8``` and ```napi_get_value_string_utf16``` to accept a null output buffer and return the length of the source string in that case via the ```result``` parameter - Remove ```napi_get_value_string_utf8_length``` and ```napi_get_value_string_utf16_length``` due to the above - Change ```Reference``` ctor and dtor to be protected and added public ```static Reference* Reference::New``` and ```static void Reference::Delete``` methods to make it more clear how the ```Reference``` objects are allocated and cleaned-up - Add a type check to ``napi_get_array_length``` which returns an error if the argument is not an array object - Change ```napi_create_symbol``` to take a ```napi_value``` instead of a ```const char*``` for the symbol description string. The API now throws if description is not a string but NULL is allowed. * Remove UTF-8 BOM characters and other non-ANSI whitespace * Change parameter names for create string APIs and address other feedback * Fixes for unit tests * Fix lint errors found via CI
This was referenced Feb 11, 2024
This was referenced Feb 11, 2024
This was referenced Feb 12, 2024
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Aug 28, 2024
* [wasi] Stop using V8 fast API * Revert "[wasi] Stop using V8 fast API" This reverts commit 0d5d171. * Revert "[v8] Stop using deprecated fields of v8::FastApiCallbackOptions (nodejs#192)" This reverts commit 286ed38.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change of
Object.keysin ES6 breaksassert.deepEqualabout primitive values.V8: https://code.google.com/p/v8/issues/detail?id=3443
Previously
deepEqualdepends onObject.keythat throws an error for a primitive value, but now it does not throw.Following tests should not pass, but pass currently.
This patch fix them.