Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add watson to collaborators #19234

Closed
wants to merge 1 commit into from
Closed

doc: add watson to collaborators #19234

wants to merge 1 commit into from

Conversation

watson
Copy link
Member

@watson watson commented Mar 8, 2018 •
edited
Loading

Closes #18943

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 8, 2018
mcollina
mcollina approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 8, 2018
@BridgeAR BridgeAR added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 8, 2018
watson added a commit that referenced this pull request Mar 8, 2018
@watson
doc: add watson to collaborators
3dfce5c 
Closes: #18943

PR-URL: #19234
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@watson
Copy link
Member Author

watson commented Mar 8, 2018

Landed in 3dfce5c

@watson watson closed this Mar 8, 2018
@watson watson deleted the addme branch March 8, 2018 17:43
@Trott
Copy link
Member

Trott commented Mar 8, 2018

Welcome! 🎉

(No CI? The onboarding doc says to start a CI for PRs like this.)

@Trott
Copy link
Member

Trott commented Mar 8, 2018

Never mind! I found the CI!

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/238/

@watson
Copy link
Member Author

watson commented Mar 8, 2018

@Trott thanks 😃yeah I ran the lite CI, as it was just a docs update

targos pushed a commit that referenced this pull request Mar 17, 2018
@watson @targos
doc: add watson to collaborators
6f4141e 
Closes: #18943

PR-URL: #19234
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@watson @MylesBorins
doc: add watson to collaborators
5c21d16 
Closes: #18943

PR-URL: #19234
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@watson @MayaLekova
doc: add watson to collaborators
b9ec633 
Closes: nodejs#18943

PR-URL: nodejs#19234
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
@watson @MylesBorins
doc: add watson to collaborators
b9b422a 
Closes: #18943

PR-URL: #19234
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@richardlau richardlau richardlau approved these changes

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@silverwind silverwind silverwind approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.