[v9.x backport] http2: callback valid check before closing request

[trivikr]

Do not close the request if callback is not a function, and
throw ERR_INVALID_CALLBACK TypeError

PR-URL: #19061
Fixes: #18855
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Ruben Bridgewater [email protected]
Reviewed-By: Shingo Inoue [email protected]
Reviewed-By: Tobias Nießen [email protected]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[MylesBorins]

the test from this PR appears to be failing. Can you please test locally to verify

edit: changed above phrasing... did not mean to imply "can you please test before pushing" rather "please test to verify it is broken"

[MylesBorins]

=== release test-http2-client-rststream-before-connect ===
Path: parallel/test-http2-client-rststream-before-connect
(node:3048) ExperimentalWarning: The http2 module is an experimental API.
assert.js:49
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: 'The "code" argument is out of range' === 'The value of "code" is out of range.'
    at Object.innerFn (/Users/mborins/code/node/v9.x/test/common/index.js:705:16)
    at expectedException (assert.js:252:19)
    at Function.throws (assert.js:297:16)
    at Object.expectsError (/Users/mborins/code/node/v9.x/test/common/index.js:727:12)
    at Http2Server.server.listen.common.mustCall (/Users/mborins/code/node/v9.x/test/parallel/test-http2-client-rststream-before-connect.js:21:10)
    at Http2Server.<anonymous> (/Users/mborins/code/node/v9.x/test/common/index.js:477:15)
    at Object.onceWrapper (events.js:272:13)
    at Http2Server.emit (events.js:180:13)
    at emitListeningNT (net.js:1372:10)
    at process._tickCallback (internal/process/next_tick.js:114:19)
Command: out/Release/node /Users/mborins/code/node/v9.x/test/parallel/test-http2-client-rststream-before-connect.js
[00:00|% 100|+   0|-   1]: Done

[targos]

ping @trivikr. It looks like the message test needs to be adapted to v9.x

[trivikr]

The test is successful in my local workspace

And the value for ERR_OUT_OF_RANGE hasn't changed in v9.x-staging branch https://github.com/nodejs/node/blob/v9.x-staging/lib/internal/errors.js#L689

However, it looks like the errors were updated in master branch in commit 6e1c25c
This is going to impact multiple tests https://github.com/nodejs/node/search?p=2&q=ERR_OUT_OF_RANGE&type=&utf8=%E2%9C%93

cc: @BridgeAR

[targos]

@trivikr The test does not check for the right error message (it is different between master and v9.x). It's weird that it passes in your local workspace.

[targos]

Rebased and landed in 2bdf3ca