Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] src: fix util abort #19223

Closed
wants to merge 1 commit into from
Closed

[9.x] src: fix util abort #19223

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Mar 8, 2018 •
edited
Loading

This makes sure util.isRegExp and util.isDate will not abort in case
more than one argument is passed to the function.

This got fixed in #18415 in 10.x. So this is a direct fix for 9.x instead of a backport.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
src: fix util abort
35deab2 
This makes sure util.isRegExp and util.isDate will not abort in case
more than one argument is passed to the function.
@BridgeAR BridgeAR added the v9.x label Mar 8, 2018
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module. v9.x labels Mar 8, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Mar 8, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/13584/

@BridgeAR BridgeAR mentioned this pull request Mar 8, 2018
Closed
4 tasks
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2018
@BridgeAR BridgeAR mentioned this pull request Mar 20, 2018
Closed
4 tasks
@MylesBorins MylesBorins force-pushed the v9.x-staging branch 3 times, most recently from d457b9d to 03c321a Compare March 20, 2018 11:56
MylesBorins
MylesBorins approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@BridgeAR @MylesBorins
src: fix util abort
49391a7 
This makes sure util.isRegExp and util.isDate will not abort in case
more than one argument is passed to the function.

PR-URL: #19223
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins
Copy link
Contributor

landed in 49391a7

@targos targos mentioned this pull request Mar 20, 2018
Merged
@BridgeAR BridgeAR deleted the v9-fix-util-abort branch April 1, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BridgeAR @MylesBorins @nodejs-github-bot