doc: add references to crypto.getCurves() #1918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -814,6 +815,7 @@ The numeric representation of the local port. | |||
| [Chrome's 'modern cryptography' setting]: http://www.chromium.org/Home/chromium-security/education/tls#TOC-Deprecation-of-TLS-Features-Algorithms-in-Chrome | |||
| [specific attacks affecting larger AES key sizes]: https://www.schneier.com/blog/archives/2009/07/another_new_aes.html | |||
| [BEAST attacks]: http://blog.ivanristic.com/2011/10/mitigating-the-beast-attack-on-tls.html | |||
| [crypto.getCurves()]: #crypto_crypto_getcurves | |||
There was a problem hiding this comment.
This link won't work as-is since getCurves() is in a different document. I think it needs to be crypto.html#crypto_crypto_getcurves
There was a problem hiding this comment.
Ah, thanks. Wasn't sure about those links.
This adds references to the newly available crypto.getCurves method where appropriate.
|
Updated that link |
|
LGTM |
silverwind
added a commit
that referenced
this pull request
Jun 9, 2015
This adds references to the newly available crypto.getCurves method where appropriate. PR-URL: #1918 Reviewed-By: Brian White <[email protected]>
|
Thanks, landed in 9f3a03f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds references to the newly available crypto.getCurves (#1914) method where appropriate. I kept the openssl bits as it gives a bit more detail about the curves.
cc: @mscdex