Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: do not inherit the no-half-open enforcer #18974

Closed
wants to merge 2 commits into from
Closed

net: do not inherit the no-half-open enforcer #18974

wants to merge 2 commits into from
+54 −32

Commits on Mar 7, 2018

  1. stream: make Duplex inherits from DuplexBase 

    Add ability to subclass `stream.Duplex` without inheriting the
"no-half-open enforcer" regardless of the value of the `allowHalfOpen`
option.
    @lpinca
    lpinca committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    dc3969e View commit details
    Browse the repository at this point in the history

  2. net: do not inherit the no-half-open enforcer 

    `Socket.prototype.destroySoon()` is called as soon as `UV_EOF` is read
if the `allowHalfOpen` option is disabled. This already works as a
"no-half-open enforcer" so there is no need to inherit another from
`stream.Duplex`.
    @lpinca
    lpinca committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    5b73a79 View commit details
    Browse the repository at this point in the history