Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x backport] src: fix GetCpuProfiler() deprecation warning #18959

Closed
wants to merge 1 commit into from
Closed

[v9.x backport] src: fix GetCpuProfiler() deprecation warning #18959

wants to merge 1 commit into from

Commits on Feb 23, 2018

  1. src: fix GetCpuProfiler() deprecation warning 

    Replace `v8::Isolate::GetCpuProfiler()` with `v8::CpuProfiler::New()`
and cache the instance; creating and disposing an instance every loop
tick is too expensive.

PR-URL: nodejs#18534
Fixes: nodejs#18039
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
    @bnoordhuis @danbev
    bnoordhuis authored and danbev committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    2a52d46 View commit details
    Browse the repository at this point in the history