Fixed broken link in onboarding.md. Removed Members team link. #18878
Conversation
There was a problem hiding this comment.
I can see how this is confusing to a reader who does not have access to the original link. The original link is not broken if you are a member of the nodejs GitHub org with sufficient privileges. Since that is the intended audience of that part of the document, the link should remain as is. The original link is where the interface for adding the individual is, so it is the most useful link. The link to the list of Collaborators in the README, on the other hand, is definitely not where we want the onboarder to add the onboardee because that's the onboardee's exercise later in the doc.
That said, the members team is one where we should probably not be adding people to it, so removing that link is 👍 by me. (I'm slowly-but-surely converting other teams to be sub-teams of the members team, so adding people directly will be unnecessary.)
|
Thanks for clarifying. I've reverted the link back and left the members link out, as you requested. |
doc/onboarding.md
Outdated
| * Prior to the onboarding session, add the new Collaborator to | ||
| [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators), | ||
| and to [the Members team](https://github.com/orgs/nodejs/teams/members) if | ||
| * Prior to the onboarding session, add the new Collaborator to the |
There was a problem hiding this comment.
Looks like there's an extra the at the end of this line (or an extra one at the beginning of the next line).
doc/onboarding.md
Outdated
| [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators), | ||
| and to [the Members team](https://github.com/orgs/nodejs/teams/members) if | ||
| * Prior to the onboarding session, add the new Collaborator to the | ||
| [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators), if |
There was a problem hiding this comment.
Totally a nit: but the additional comma isn't necessary. It doesn't hurt anything either. But to reduce the diff to the bare minimum, maybe get rid of it so this line is unchanged?
There was a problem hiding this comment.
FWIW, this line would be changed either way, the last word comes from the next line on the left side of the diff. Speaking of which, I'd say it should stay on the next line to keep this one under 80 characters.
There was a problem hiding this comment.
I've removed the comma and got rid of the spare 'the', sorry I missed that!
doc/onboarding.md
Outdated
| @@ -15,8 +15,7 @@ onboarding session. | |||
| ## Fifteen minutes before the onboarding session | |||
|
|
|||
| * Prior to the onboarding session, add the new Collaborator to | |||
| [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators), | |||
| and to [the Members team](https://github.com/orgs/nodejs/teams/members) if | |||
| [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators) if | |||
There was a problem hiding this comment.
Sorry I didn't think of this before but they will not already be a part of the nodejs/collaborators team, so the if they are not already part of it can be removed too. :-D
There was a problem hiding this comment.
(The if they are not already part of it applied to nodejs/members.)
There was a problem hiding this comment.
No worries, I've made the change now.
|
No problem! |
BridgeAR
added
the
author ready
|
CI failure unrelated, going to land this |
|
Landed in cadc907 - thank you for your contribution! |
Remove link to the outdated members team PR-URL: #18878 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Remove link to the outdated members team PR-URL: #18878 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Remove link to the outdated members team PR-URL: nodejs#18878 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Remove link to the outdated members team PR-URL: #18878 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Remove link to the outdated members team PR-URL: nodejs#18878 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
These two links are broken:
https://github.com/orgs/nodejs/teams/collaborators
https://github.com/orgs/nodejs/teams/members
I've relinked the collaborators to the main README.md's collaborator section, but could not find a member's section to link to, so I removed it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)