Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: http2 errors on req.close() #18854

Closed
wants to merge 1 commit into from
Closed

test: http2 errors on req.close() #18854

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 18, 2018

This code adds test for the following code:

node/lib/internal/http2/core.js

Line 1743 in 472cde6

throw new errors.RangeError('ERR_OUT_OF_RANGE', 'code');

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 18, 2018
@trivikr trivikr mentioned this pull request Feb 18, 2018
Closed
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 21, 2018
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/13308/

@addaleax
Copy link
Member

Landed in 15e02ce

@addaleax addaleax closed this Feb 21, 2018
addaleax pushed a commit that referenced this pull request Feb 21, 2018
@trivikr @addaleax
test: http2 errors on req.close()
15e02ce 
PR-URL: #18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 6, 2018
Closed
4 tasks
@MylesBorins
Copy link
Contributor

This should be included in a backport of #18669

@trivikr trivikr deleted the test-http2-close branch March 8, 2018 14:49
@targos targos added backport-requested-v9.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v9.x labels Mar 24, 2018
targos pushed a commit to targos/node that referenced this pull request Mar 24, 2018
@trivikr @targos
test: http2 errors on req.close()
b4a99a7 
PR-URL: nodejs#18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Mar 24, 2018
Closed
targos pushed a commit that referenced this pull request Mar 30, 2018
@trivikr @targos
test: http2 errors on req.close()
6bc49f0 
Backport-PR-URL: #19579
PR-URL: #18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Apr 4, 2018
Merged
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@trivikr @kjin
test: http2 errors on req.close()
9d885b9 
Backport-PR-URL: nodejs#19579
PR-URL: nodejs#18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@trivikr @MylesBorins
test: http2 errors on req.close()
f5a2cd5 
Backport-PR-URL: #19579
Backport-PR-URL: #20456
PR-URL: #18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@trivikr @MayaLekova
test: http2 errors on req.close()
6b5a569 
PR-URL: nodejs#18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@trivikr @MylesBorins
test: http2 errors on req.close()
42778c3 
Backport-PR-URL: #19579
Backport-PR-URL: #20456
PR-URL: #18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@trivikr @MylesBorins
test: http2 errors on req.close()
4dbdb8a 
Backport-PR-URL: #19579
Backport-PR-URL: #20456
PR-URL: #18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@daynin daynin daynin approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@trivikr @BridgeAR @addaleax @MylesBorins @jasnell @daynin @lpinca @cjihrig @targos @nodejs-github-bot