Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: enforce max-line-length lint rule #18722

Closed
wants to merge 1 commit into from
Closed

doc: enforce max-line-length lint rule #18722

wants to merge 1 commit into from

Conversation

gideontee
Copy link
Contributor

Includes 80 character limit for docs linter.

I managed to add the linter rule for the docs, but I'm not sure of an elegant way to fix
existing lines than exceed 80 characters.

Fixes: #18703

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Includes 80 character limit for docs linter

Fixes: #18703
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 12, 2018
@BridgeAR
Copy link
Member

@jiaherrt thanks a lot for your contribution. Before this can be added, the wrong lines have to be fixed though so there are no broken linter runs.

It seems like shortly after you opened your PR a conflicting PR came in that did the same including those changes. See #18726. As yours was first, we normally try to get in the first PR. But since more work is necessary here, I guess it might be good to preference the second one? Would that be OK for you? Otherwise we could go ahead and try to first land the second one without adding the rule itself and then land this PR.

@gideontee
Copy link
Contributor Author

I see. Since I see there's already lots of progress made in the second PR, I'll close this PR then. No worries.

@gideontee gideontee closed this Feb 12, 2018
@gideontee gideontee deleted the doc-lint-rule branch February 12, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New documentation lint rule
3 participants