doc: Fix http.IncomingMessage.socket documentation #1867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the reference to net.Socket.verifyPeer(). That was removed in ea540c9 and was missed in the 032f80e. Refer to the net.Socket instance by the .socket property. This avoids unneeded confusion. '.socket' is the variant that is used internally. Add a markdown link to net.Socket.getPeerCertificate().
ChALkeR
force-pushed
the
doc-http-incomingmessage-socket
branch
from
5cf9442
to
cbf485a
Compare
mscdex
added
http
|
This leaves |
bnoordhuis
pushed a commit
that referenced
this pull request
Jun 1, 2015
Remove the reference to net.Socket.verifyPeer(). That was removed in ea540c9 and was missed in the 032f80e. Refer to the net.Socket instance by the .socket property. This avoids unneeded confusion. '.socket' is the variant that is used internally. Add a markdown link to net.Socket.getPeerCertificate(). PR-URL: #1867 Reviewed-By: Ben Noordhuis <[email protected]>
|
Landed in 89a5b90, thanks. Fixed up a long line in the process. |
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
Remove the reference to net.Socket.verifyPeer(). That was removed in ea540c9 and was missed in the 032f80e. Refer to the net.Socket instance by the .socket property. This avoids unneeded confusion. '.socket' is the variant that is used internally. Add a markdown link to net.Socket.getPeerCertificate(). PR-URL: nodejs/node#1867 Reviewed-By: Ben Noordhuis <[email protected]>
This was referenced Jun 22, 2023
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the reference to
net.Socket.verifyPeer().That was removed in ea540c9 (2010) and was missed in the 032f80e (a follow-up documentation update).
Refer to the
net.Socketinstance by the.socketproperty. This avoids unneeded confusion..socketis the variant that is used internally (and that was mentioned two lines above in the docs).Add a markdown link to
net.Socket.getPeerCertificate().