Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused variable #18385

Merged
merged 1 commit into from
Jan 28, 2018
Merged

src: remove unused variable #18385

merged 1 commit into from
Jan 28, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 25, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 25, 2018
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 26, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/12748/

EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/12749/

@cjihrig
src: remove unused variable
0be9cd2 
PR-URL: nodejs#18385
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@cjihrig cjihrig merged commit 0be9cd2 into nodejs:master Jan 28, 2018
@cjihrig cjihrig deleted the unused branch January 28, 2018 00:19
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@cjihrig @evanlucas
src: remove unused variable
ecf5bea 
PR-URL: #18385
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@MylesBorins
Copy link
Contributor

should we apply to LTS? my gut is no

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@cjihrig @MayaLekova
src: remove unused variable
039c089 
PR-URL: nodejs#18385
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@maclover7 maclover7 maclover7 approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @MylesBorins @danbev @jasnell @maclover7 @joyeecheung @richardlau @nodejs-github-bot