errors: improve the description of ERR_INVALID_ARG_VALUE #18358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow user to customize why the argument is invalid - Display the argument with util.inspect so null bytes can be displayed properly.
nodejs-github-bot
added
the
errors
3 tasks
jasnell
approved these changes
Jan 24, 2018
3 tasks
|
CI failures look unrelated. |
joyeecheung
added
the
author ready
maclover7
approved these changes
Jan 26, 2018
|
Landed in 3ec7921, thanks! |
joyeecheung
removed
the
author ready
joyeecheung
added a commit
that referenced
this pull request
Jan 29, 2018
- Allow user to customize why the argument is invalid - Display the argument with util.inspect so null bytes can be displayed properly. PR-URL: #18358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
|
This does not land cleanly on v9.x, would it be a good idea the backport? |
joyeecheung
added a commit
to joyeecheung/node
that referenced
this pull request
Feb 22, 2018
- Allow user to customize why the argument is invalid - Display the argument with util.inspect so null bytes can be displayed properly. PR-URL: nodejs#18358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 26, 2018
- Allow user to customize why the argument is invalid - Display the argument with util.inspect so null bytes can be displayed properly. Backport-PR-URL: #18916 PR-URL: #18358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 26, 2018
- Allow user to customize why the argument is invalid - Display the argument with util.inspect so null bytes can be displayed properly. Backport-PR-URL: #18916 PR-URL: #18358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Closed
joyeecheung
added a commit
to joyeecheung/node
that referenced
this pull request
May 2, 2018
PR-URL: nodejs#18358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
- Allow user to customize why the argument is invalid - Display the argument with util.inspect so null bytes can be displayed properly. PR-URL: nodejs#18358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
Backport-PR-URL: #19191 PR-URL: #18358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 14, 2018
Backport-PR-URL: #19191 PR-URL: #18358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Merged
|
@joyeecheung this doesn't apply cleanly to |
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
Backport-PR-URL: #19191 PR-URL: #18358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
|
I don't believe this one should be backported to 8.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
displayed properly.
Spinning off from #18308 , but I think this can be submitted alone since that one needs a bit more reviews to land and that's semver-major. The current formatter does not allow users to explain why the argument is invalid and it displays the argument with
${String(value)}which cannot display null bytes properly. This patch makes the error message more debuggable.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors