src: fix typo in trace_events_async_hooks.js #18280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrome://traceing does not exist
gillesdemey
changed the title
vsemozhetbyt
added
async_hooks
vsemozhetbyt
approved these changes
Jan 21, 2018
|
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/105/ (it seems this suffices as the PR only changes a comment). |
maclover7
approved these changes
Jan 21, 2018
targos
approved these changes
Jan 21, 2018
vsemozhetbyt
pushed a commit
that referenced
this pull request
Jan 21, 2018
chrome://traceing does not exist PR-URL: #18280 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
Landed in 9545c48 Thank you, @gillesdemey! |
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
chrome://traceing does not exist PR-URL: #18280 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
chrome://traceing does not exist PR-URL: #18280 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
nvm, was able to do it myself.. was on autopilot, sorry for noise |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
chrome://traceing does not exist PR-URL: #18280 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
chrome://traceing does not exist PR-URL: nodejs#18280 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chrome://traceingdoes not existChecklist
Affected core subsystem(s)
none