Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "core: set PROVIDER type as Persistent class id" #1827

Merged
merged 1 commit into from
May 28, 2015
Merged

Revert "core: set PROVIDER type as Persistent class id" #1827

merged 1 commit into from
May 28, 2015

Commits on May 28, 2015

  1. Revert "core: set PROVIDER type as Persistent class id" 

    This reverts commit 3c44100.

Reverted for breaking node-heapdump[0].

AsyncWrap assigns a class id but does not set a v8::RetainedObjectInfo
provider callback with v8::HeapProfiler::SetWrapperClassInfoProvider().
The result is a null pointer dereference when taking a heap snapshot.

It can probably be solved by setting a generic provider callback inside
the AsyncWrap constructor but that may have performance ramifications
that need to be investigated first.  I move to revert it for now.

[0] https://github.com/bnoordhuis/node-heapdump

PR-URL: nodejs#1827
Reviewed-By: Trevor Norris <[email protected]>
    @bnoordhuis
    bnoordhuis committed May 28, 2015
    Configuration menu
    Copy the full SHA
    3a1bc06 View commit details
    Browse the repository at this point in the history