Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http/net: fix catching immediate connect errors #1823

Closed

Commits on May 28, 2015

  1. http/net: fix catching immediate connect errors

    When creating a standard http client request the agent is calling
    net.createConnection. The agent will then defer installing error
    handling to nextTick(). If there is any immediate error in
    createConnection iojs will bail with an uncaught error. There is already
    one error situation which is handled in a special way (i.e. throwing
    error is deferred so the standard error handler may catch it). However
    there are more situations where this may happen: Namely in the connect()
    function.
    m0ppers committed May 28, 2015
    Configuration menu
    Copy the full SHA
    6fbd074 View commit details
    Browse the repository at this point in the history