Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove old code #1819

Closed

Conversation

brendanashworth
Copy link
Contributor

The Socket writable-only change was added and implemented in the
constructor around 5885f46, but this was never removed.

The libev counter issue is no longer prudent; the test remains in
test/sequential/test-regress-GH-1726.

The Socket writable only change was added and implemented in the
constructor around 5885f46, but this was never removed.

The libev counter issue is no longer prudent; the test remains in
test/sequential/test-regress-GH-1726.
@brendanashworth
Copy link
Contributor Author

ref: #264

@bnoordhuis
Copy link
Member

LGTM

@bnoordhuis
Copy link
Member

Oh, maybe run the CI just in case.

@brendanashworth
Copy link
Contributor Author

@brendanashworth
Copy link
Contributor Author

CI is happy minus an unrelated ARM failure.

brendanashworth added a commit that referenced this pull request May 30, 2015
The Socket writable only change was added and implemented in the
constructor around 5885f46, but this was never removed.

The libev counter issue is no longer prudent; the test remains in
test/sequential/test-regress-GH-1726.

PR-URL: #1819
Reviewed-By: Ben Noordhuis <[email protected]>
@brendanashworth
Copy link
Contributor Author

Landed in a65762c, thanks.

@rvagg rvagg mentioned this pull request May 31, 2015
andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this pull request Jun 3, 2015
The Socket writable only change was added and implemented in the
constructor around 5885f46, but this was never removed.

The libev counter issue is no longer prudent; the test remains in
test/sequential/test-regress-GH-1726.

PR-URL: nodejs/node#1819
Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants