Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: add a number of checks for server close callback #18182

Closed
wants to merge 1 commit into from
Closed

http2: add a number of checks for server close callback #18182

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 16, 2018

Verify that server close callbacks are being called

Refs: #18176

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@jasnell
http2: add a number of checks for server close callback
a9c3f36 
Verify that server close callbacks are being called
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 16, 2018
@jasnell
Copy link
Member Author

jasnell commented Jan 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12559/

@jasnell jasnell added the http2 Issues or PRs related to the http2 subsystem. label Jan 16, 2018
@addaleax addaleax added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 17, 2018
@BridgeAR
Copy link
Member

Landed in 0a1adc0

@BridgeAR BridgeAR closed this Jan 19, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 19, 2018
@jasnell @BridgeAR
http2: add checks for server close callback
0a1adc0 
Verify that server close callbacks are being called

PR-URL: nodejs#18182
Refs: nodejs#18176
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@jasnell @evanlucas
http2: add checks for server close callback
9c16171 
Verify that server close callbacks are being called

PR-URL: #18182
Refs: #18176
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@jasnell @evanlucas
http2: add checks for server close callback
ee6217a 
Verify that server close callbacks are being called

PR-URL: #18182
Refs: #18176
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins
Copy link
Contributor

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@jasnell @kjin
http2: add checks for server close callback
9ff0e8c 
Verify that server close callbacks are being called

PR-URL: nodejs#18182
Refs: nodejs#18176
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@jasnell @MylesBorins
http2: add checks for server close callback
ac64b4f 
Verify that server close callbacks are being called

Backport-PR-URL: #20456
PR-URL: #18182
Refs: #18176
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@jasnell @MayaLekova
http2: add checks for server close callback
f5a300a 
Verify that server close callbacks are being called

PR-URL: nodejs#18182
Refs: nodejs#18176
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @BridgeAR @MylesBorins @addaleax @nodejs-github-bot