test: add test for failed save in REPL #1818
Conversation
Trott
force-pushed
the
test-failed-save
branch
2 times, most recently
from
c1ab67f
to
c373204
Compare
|
Can someone throw this into Jenkins to make sure it actually works for all the operating systems? It should, but uh...you know... |
| // make sure I get a failed to save message and not some other error | ||
| assert.equal(data, 'Failed to save:' + invalidFileName + '\n'); | ||
| // reset to no-op | ||
| putIn.write = function() {}; |
There was a problem hiding this comment.
We want to test that when the file can't be saved, the REPL reports that to the user rather than (say) failing silently.
There was a problem hiding this comment.
It might be clearer and more robust to override fs.writeFileSync() or whatever so that it triggers an error no matter what. Downside is that ties the test to the REPL implementation a little more closely than one might like.
|
Pushed commit to change (Unfortunately, the rebase to master means that |
|
Rebased to get test fix, runs clean now, woot. |
|
LGTM if the tests pass. |
PR-URL: #1818 Reviewed-By: Chris Dickinson <[email protected]>
|
Merged in 8ea6844 |
Getting rid of a
TODOcomment (#264)