Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: setEncoding error for incoming packets #18178

Closed
wants to merge 2 commits into from
Closed

http: setEncoding error for incoming packets #18178

wants to merge 2 commits into from

Commits on Feb 3, 2018

  1. http: setEncoding override for incoming packets 

    added override to socket.setEncoding to not allow encoding changes for
incoming HTTP requests
added tests to ensure method throws JavaScript error
because an HTTP buffer must be in US-ASCII, this function should not
be allowed and should throw an Error
currently, the process encounters a fatal v8 error and crashes

error report detailed in
[issue #18118](#18118)

Fixes: #18118
Ref: #18178
    @iSkore
    iSkore committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    28d7955 View commit details
    Browse the repository at this point in the history

  2. http: setEncoding override for incoming packets 

    added override to socket.setEncoding to not allow encoding changes for
incoming HTTP requests
added tests to ensure method throws JavaScript error
because an HTTP buffer must be in US-ASCII, this function should not
be allowed and should throw an Error
currently, the process encounters a fatal v8 error and crashes

error report detailed in
[issue #18118](#18118)

Fixes: #18118
Ref: #18178
    @iSkore
    iSkore committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    a882258 View commit details
    Browse the repository at this point in the history