Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: migrate FSEventWrap error to JS #18154

Closed
wants to merge 1 commit into from
Closed

fs: migrate FSEventWrap error to JS #18154

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jan 15, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Jan 15, 2018
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Jan 15, 2018
@joyeecheung
Copy link
Member

This looks like a duplicate of #17851 ? @maclover7 are you still pursuing that PR?

@targos
Copy link
Member Author

targos commented Jan 15, 2018

You are right, thanks! I didn't find that PR with my initial search.

@targos targos closed this Jan 15, 2018
@targos targos deleted the errors-fseventwrap branch October 17, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. errors Issues and PRs related to JavaScript errors originated in Node.js core. fs Issues and PRs related to the fs subsystem / file system. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@targos @joyeecheung @nodejs-github-bot