Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process 100, 102-199 status codes according to specs. #18033

Closed
wants to merge 20 commits into from

Commits on Feb 10, 2018

  1. Process 100, 102-199 status codes according to specs.

    Relevant references:
     RFC7231 Section 6.2.1
     RFC2518
     RFC8297
    
    This affects several modules downstream that use the http
    module, e.g., node-fetch, all of whom violate HTTP RFCs
    due to this module. As such, this could introduce a
    breaking change for downstream if HTTP standards were
    ignored in an ad-hoc fashion.
    
    101 Upgrade is excluded due to its non-informational
    processing according to RFC7231, Section 6.2.2.
    miles-po committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    5200fab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fba79a8 View commit details
    Browse the repository at this point in the history
  3. Cleaning up code to reuse informational status check.

    Lint is clean.
    miles-po committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    58bb0ca View commit details
    Browse the repository at this point in the history
  4. Fine tuning comment change.

    miles-po committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    79301fa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b2c81fc View commit details
    Browse the repository at this point in the history
  6. Firing event for information messages

    Must be distinct from `continue` event due to slightly different
    behavior/triggering rules from 102/103 status codes. For example,
    103 is explicitly made to take headers for pre-processing while 100
    status codes never include headers.
    miles-po committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    fd33e98 View commit details
    Browse the repository at this point in the history
  7. Adding writeInformation to handle 1xx status codes

    `writeContinue` is highly specific to 100 status codes and sets state
    for further processing. For example, keep-alive behavior is changed by
    100 responses. `writeContinue` also cannot set header values, needed by
    103 responses (so far).
    miles-po committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    2113f0a View commit details
    Browse the repository at this point in the history
  8. Adding 102 Processing test

    miles-po committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    65405c4 View commit details
    Browse the repository at this point in the history
  9. Renaming 102 status test

    miles-po committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    ea72928 View commit details
    Browse the repository at this point in the history
  10. Added test for 103 Early Hints

    Since 103 is affected by this patch, added test. 104-199 is not yet
    defined, so leaving behavior undefined with no explicit tests.
    miles-po committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    29cae69 View commit details
    Browse the repository at this point in the history
  11. Making a record

    miles-po committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    5f4049c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d7bacbb View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    12e0566 View commit details
    Browse the repository at this point in the history
  14. Addressing notes by @mcollina

    * Replace v10.0.0 with REPLACEME in the http documentation
    * Removed `_writeInformation`
    * Removed test copyright header
    * Removed `process.exit` from test
    miles-po committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    e51c7ae View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    0386a11 View commit details
    Browse the repository at this point in the history
  16. Fixed line length

    miles-po committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    e46b997 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2018

  1. Removed HTTP/2 doc updates

    HTTP/2 changes will be done in a separate PR.
    miles-po committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    130e729 View commit details
    Browse the repository at this point in the history
  2. Fixed rebase errors and nits

    * While rebasing, old content resurfaced. Re-removed.
    * Removed errant 'client' comment
    * Removed assert descriptions
    * Used common/countdown instead of simple int
    * Capitalized initial letter in example comment
    miles-po committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    89e4552 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1eee678 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2018

  1. Configuration menu
    Copy the full SHA
    1c2e86d View commit details
    Browse the repository at this point in the history