-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process 100, 102-199 status codes according to specs. #18033
Commits on Feb 10, 2018
-
Process 100, 102-199 status codes according to specs.
Relevant references: RFC7231 Section 6.2.1 RFC2518 RFC8297 This affects several modules downstream that use the http module, e.g., node-fetch, all of whom violate HTTP RFCs due to this module. As such, this could introduce a breaking change for downstream if HTTP standards were ignored in an ad-hoc fashion. 101 Upgrade is excluded due to its non-informational processing according to RFC7231, Section 6.2.2.
Configuration menu - View commit details
-
Copy full SHA for 5200fab - Browse repository at this point
Copy the full SHA 5200fabView commit details -
Configuration menu - View commit details
-
Copy full SHA for fba79a8 - Browse repository at this point
Copy the full SHA fba79a8View commit details -
Cleaning up code to reuse informational status check.
Lint is clean.
Configuration menu - View commit details
-
Copy full SHA for 58bb0ca - Browse repository at this point
Copy the full SHA 58bb0caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79301fa - Browse repository at this point
Copy the full SHA 79301faView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2c81fc - Browse repository at this point
Copy the full SHA b2c81fcView commit details -
Firing event for information messages
Must be distinct from `continue` event due to slightly different behavior/triggering rules from 102/103 status codes. For example, 103 is explicitly made to take headers for pre-processing while 100 status codes never include headers.
Configuration menu - View commit details
-
Copy full SHA for fd33e98 - Browse repository at this point
Copy the full SHA fd33e98View commit details -
Adding writeInformation to handle 1xx status codes
`writeContinue` is highly specific to 100 status codes and sets state for further processing. For example, keep-alive behavior is changed by 100 responses. `writeContinue` also cannot set header values, needed by 103 responses (so far).
Configuration menu - View commit details
-
Copy full SHA for 2113f0a - Browse repository at this point
Copy the full SHA 2113f0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65405c4 - Browse repository at this point
Copy the full SHA 65405c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea72928 - Browse repository at this point
Copy the full SHA ea72928View commit details -
Added test for 103 Early Hints
Since 103 is affected by this patch, added test. 104-199 is not yet defined, so leaving behavior undefined with no explicit tests.
Configuration menu - View commit details
-
Copy full SHA for 29cae69 - Browse repository at this point
Copy the full SHA 29cae69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f4049c - Browse repository at this point
Copy the full SHA 5f4049cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7bacbb - Browse repository at this point
Copy the full SHA d7bacbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12e0566 - Browse repository at this point
Copy the full SHA 12e0566View commit details -
* Replace v10.0.0 with REPLACEME in the http documentation * Removed `_writeInformation` * Removed test copyright header * Removed `process.exit` from test
Configuration menu - View commit details
-
Copy full SHA for e51c7ae - Browse repository at this point
Copy the full SHA e51c7aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0386a11 - Browse repository at this point
Copy the full SHA 0386a11View commit details -
Configuration menu - View commit details
-
Copy full SHA for e46b997 - Browse repository at this point
Copy the full SHA e46b997View commit details
Commits on Feb 12, 2018
-
HTTP/2 changes will be done in a separate PR.
Configuration menu - View commit details
-
Copy full SHA for 130e729 - Browse repository at this point
Copy the full SHA 130e729View commit details -
* While rebasing, old content resurfaced. Re-removed. * Removed errant 'client' comment * Removed assert descriptions * Used common/countdown instead of simple int * Capitalized initial letter in example comment
Configuration menu - View commit details
-
Copy full SHA for 89e4552 - Browse repository at this point
Copy the full SHA 89e4552View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1eee678 - Browse repository at this point
Copy the full SHA 1eee678View commit details
Commits on Feb 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1c2e86d - Browse repository at this point
Copy the full SHA 1c2e86dView commit details