Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: move matthewloring to emeriti #17998

Closed
wants to merge 1 commit into from
Closed

doc: move matthewloring to emeriti #17998

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 5, 2018

At some point, Matt Loring got removed from the Collaborators GitHub team but was left in the list in the README. This moves him to the Emeriti section so that the Collaborators list matches the GitHub team.

@matthewloring If the removal from the Collaborators GitHub team was in error, please let me know and I'll close this PR. Thanks!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@Trott
doc: move matthewloring to emeriti
29a0392 
Matt is not an active collaborator at this time. Moved to the
Collaborator Emeriti section.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 5, 2018
mcollina
mcollina approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maclover7
Copy link
Contributor

Docs CI: https://ci.nodejs.org/job/node-test-pull-request-lite/77/

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 6, 2018
jasnell pushed a commit that referenced this pull request Jan 6, 2018
@Trott @jasnell
doc: move matthewloring to emeriti
22af8ea 
Matt is not an active collaborator at this time. Moved to the
Collaborator Emeriti section.

PR-URL: #17998
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matthew Loring <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 6, 2018

Landed in 22af8ea

@jasnell jasnell closed this Jan 6, 2018
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@Trott @MylesBorins
doc: move matthewloring to emeriti
9a36c65 
Matt is not an active collaborator at this time. Moved to the
Collaborator Emeriti section.

PR-URL: #17998
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matthew Loring <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott @MylesBorins
doc: move matthewloring to emeriti
046ee75 
Matt is not an active collaborator at this time. Moved to the
Collaborator Emeriti section.

PR-URL: #17998
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matthew Loring <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott @MylesBorins
doc: move matthewloring to emeriti
72ed11a 
Matt is not an active collaborator at this time. Moved to the
Collaborator Emeriti section.

PR-URL: #17998
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matthew Loring <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
@TimothyGu TimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2018
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@Trott @MylesBorins
doc: move matthewloring to emeriti
3a6c734 
Matt is not an active collaborator at this time. Moved to the
Collaborator Emeriti section.

PR-URL: #17998
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matthew Loring <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@Trott @MylesBorins
doc: move matthewloring to emeriti
50780c1 
Matt is not an active collaborator at this time. Moved to the
Collaborator Emeriti section.

PR-URL: #17998
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matthew Loring <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@Trott @MylesBorins
doc: move matthewloring to emeriti
8121009 
Matt is not an active collaborator at this time. Moved to the
Collaborator Emeriti section.

PR-URL: #17998
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matthew Loring <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@Trott @MylesBorins
doc: move matthewloring to emeriti
bcd2075 
Matt is not an active collaborator at this time. Moved to the
Collaborator Emeriti section.

PR-URL: #17998
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matthew Loring <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@Trott @MylesBorins
doc: move matthewloring to emeriti
8f80548 
Matt is not an active collaborator at this time. Moved to the
Collaborator Emeriti section.

PR-URL: #17998
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matthew Loring <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@Trott Trott deleted the update-emeriti branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@JungMinu JungMinu JungMinu approved these changes

@tniessen tniessen tniessen approved these changes

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@matthewloring matthewloring matthewloring approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.