Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: replace wrong U+00A0 by common spaces #17940

Closed
wants to merge 1 commit into from
Closed

doc: replace wrong U+00A0 by common spaces #17940

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jan 1, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 1, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 1, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI lite: https://ci.nodejs.org/job/node-test-pull-request-lite/67/

@maclover7
Copy link
Contributor

Is there a way to add a linter rule for this that could get run as part of make lint-md?

@vsemozhetbyt
Copy link
Contributor Author

@maclover7 It should be a remark rule, if I get this right, but I am not aware of the format of these rules, unfortunately.

vsemozhetbyt added a commit that referenced this pull request Jan 2, 2018
@vsemozhetbyt
doc: replace wrong U+00A0 by common spaces
11a1bc1 
PR-URL: #17940
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 11a1bc1

@vsemozhetbyt vsemozhetbyt deleted the doc-replace-00A0 branch January 2, 2018 00:00
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@vsemozhetbyt @MylesBorins
doc: replace wrong U+00A0 by common spaces
e9a2648 
PR-URL: #17940
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@vsemozhetbyt @MylesBorins
doc: replace wrong U+00A0 by common spaces
2566bcf 
PR-URL: #17940
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@vsemozhetbyt @MylesBorins
doc: replace wrong U+00A0 by common spaces
d2b1601 
PR-URL: #17940
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@vsemozhetbyt @MylesBorins
doc: replace wrong U+00A0 by common spaces
90c5bd4 
PR-URL: #17940
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maclover7 maclover7 maclover7 approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsemozhetbyt @maclover7 @addaleax @MylesBorins @nodejs-github-bot