Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: keep session objects alive during Http2Scope #17863

Closed
wants to merge 3 commits into from
Closed

http2: keep session objects alive during Http2Scope #17863

wants to merge 3 commits into from

Commits on Dec 25, 2017

  1. http2: fix compiling with --debug-http2

    @addaleax
    addaleax committed Dec 25, 2017
    Configuration menu
    Copy the full SHA
    fab3773 View commit details
    Browse the repository at this point in the history

  2. http2: keep session objects alive during Http2Scope 

    Keep a local handle as a reference to the JS `Http2Session`
object so that it will not be garbage collected
when inside an `Http2Scope`, because the presence of the
latter usually indicates that further actions on
the session object are expected.

Strictly speaking, storing the `session_handle_` as a
property on the scope object is not necessary, but
this is not very costly and makes the code more
obviously correct.

Fixes: nodejs#17840
    @addaleax
    addaleax committed Dec 25, 2017
    Configuration menu
    Copy the full SHA
    f59774d View commit details
    Browse the repository at this point in the history

  3. [squash] apapirovski nit

    @addaleax
    addaleax committed Dec 25, 2017
    Configuration menu
    Copy the full SHA
    fcd50be View commit details
    Browse the repository at this point in the history