Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: change "less" to "fewer" in CONTRIBUTING.md #17838

Closed
wants to merge 1 commit into from
Closed

doc: change "less" to "fewer" in CONTRIBUTING.md #17838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ notes about [commit squashing](#commit-squashing)).
A good commit message should describe what changed and why.

1. The first line should:
- contain a short description of the change (preferably 50 characters or less,
- contain a short description of the change (preferably 50 characters or fewer,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe my sense as a non-native speaker is off, but with fewer, re-ordering to 50 or fewer characters sounds more natural to me? 😄

Copy link
Contributor Author

@b0yfriend b0yfriend Dec 23, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels more correct to me, too!

I live in the US. Interchanging fewer and less is common here, even when it's technically incorrect. It doesn't bother me much, actually. The distinction is pedantic.

However, I figured that I should fix it anyway. It would bother someone else eventually, I think. 🤷

and no more than 72 characters)
- be entirely in lowercase with the exception of proper nouns, acronyms, and
the words that refer to code, like function/variable names
Expand Down