Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use american spelling as per style guide #17818

Closed
wants to merge 1 commit into from
Closed

doc: use american spelling as per style guide #17818

wants to merge 1 commit into from

Conversation

sreepurnajasti
Copy link
Contributor

Use labeled instead of labelled w.r.to style guide.

Checklist
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 22, 2017
gibfahn
gibfahn reviewed Dec 22, 2017
View reviewed changes
doc/guides/backporting-to-release-lines.md Outdated
| ------------ | -------------- |
| `v7.x` | `v7.x-staging` |
| `v6.x` | `v6.x-staging` |
| `v4.x` | `v4.x-staging` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all these changes intentional? I think your commit might have been based on an old copy of master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gibfahn You are right. Sorry for that. Please review.

@tniessen
Copy link
Member

tniessen commented Dec 22, 2017 •
edited
Loading

It seems like you included other changes in your commit. Unless this was intentional, please try to revert unrelated changes. You do not need to create a new PR, just push to the same branch again.

Nit: commit message should be lowercase (Use)

@sreepurnajasti
Copy link
Contributor Author

@tniessen I completely agree. This was accidental. Please review.

@sreepurnajasti sreepurnajasti changed the title doc: Use american spelling as per style guide doc: use american spelling as per style guide Dec 23, 2017
vsemozhetbyt
vsemozhetbyt reviewed Dec 23, 2017
View reviewed changes
doc/guides/backporting-to-release-lines.md Outdated
@@ -88,4 +88,4 @@ PR with `backported-to-v6.x`.

[Release Schedule]: https://github.com/nodejs/Release#release-schedule1
[Release Plan]: https://github.com/nodejs/Release#release-plan
[`node-test-pull-request`]: https://ci.nodejs.org/job/node-test-pull-request/build
[`node-test-pull-request`]: https://ci.nodejs.org/job/node-test-pull-request/build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing line break?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It's Done!!

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/12275/

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 23, 2017
@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 23, 2017
@tniessen
Copy link
Member

Landed in 0b78895.

@tniessen tniessen closed this Dec 23, 2017
tniessen pushed a commit that referenced this pull request Dec 23, 2017
@sreepurnajasti @tniessen
doc: use american spelling as per style guide
0b78895 
PR-URL: #17818
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@sreepurnajasti sreepurnajasti deleted the doc-change branch December 27, 2017 06:34
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@sreepurnajasti @MylesBorins
doc: use american spelling as per style guide
61095df 
PR-URL: #17818
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@sreepurnajasti @MylesBorins
doc: use american spelling as per style guide
60eedfb 
PR-URL: #17818
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@sreepurnajasti @MylesBorins
doc: use american spelling as per style guide
541d189 
PR-URL: #17818
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@sreepurnajasti @gibfahn
doc: use american spelling as per style guide
7f6780d 
PR-URL: #17818
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@sreepurnajasti @gibfahn
doc: use american spelling as per style guide
b5690f9 
PR-URL: #17818
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@sreepurnajasti @gibfahn
doc: use american spelling as per style guide
673fdc6 
PR-URL: #17818
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@sreepurnajasti @MylesBorins
doc: use american spelling as per style guide
7654913 
PR-URL: #17818
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@sreepurnajasti @MylesBorins
doc: use american spelling as per style guide
afa407f 
PR-URL: #17818
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@sreepurnajasti @MylesBorins
doc: use american spelling as per style guide
2260795 
PR-URL: #17818
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sreepurnajasti @tniessen @gireeshpunathil @Trott @vsemozhetbyt @gibfahn @addaleax @nodejs-github-bot