Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix typo in test-inspector-cluster-port-clash.js #17782

Closed
wants to merge 1 commit into from
Closed

test: fix typo in test-inspector-cluster-port-clash.js #17782

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 20, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 20, 2017
@Trott
Copy link
Member Author

Trott commented Dec 20, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12223/

targos
targos approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you find this?

@Trott
Copy link
Member Author

Trott commented Dec 20, 2017

How did you find this?

I was grepping for common.* calls that only occur once so I could evaluate them for removal from the common module, and this one came up.

@Trott
Copy link
Member Author

Trott commented Dec 20, 2017

(Failures in CI are unrelated, CI is good.)

Trott added a commit to Trott/io.js that referenced this pull request Dec 20, 2017
@Trott
test: fix typo in test-inspector-cluster-port-clash.js
d6b1b84 
PR-URL: nodejs#17782
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@Trott
Copy link
Member Author

Trott commented Dec 20, 2017

Landed in d6b1b84

@Trott Trott closed this Dec 20, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@Trott @MylesBorins
test: fix typo in test-inspector-cluster-port-clash.js
3d8b0ac 
PR-URL: #17782
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott @MylesBorins
test: fix typo in test-inspector-cluster-port-clash.js
dd14004 
PR-URL: #17782
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@Trott @MylesBorins
test: fix typo in test-inspector-cluster-port-clash.js
2bf0796 
PR-URL: #17782
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@Trott @gibfahn
test: fix typo in test-inspector-cluster-port-clash.js
d3d0aaf 
PR-URL: #17782
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@Trott Trott deleted the crash branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @danbev @addaleax @targos @cjihrig @maclover7 @gireeshpunathil @MylesBorins @nodejs-github-bot