Add tests to improve internal/crypto/diffiehellman.js coverage #17728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leko
changed the title
lpinca
approved these changes
Dec 18, 2017
test/parallel/test-crypto-dh.js
Outdated
|
|
||
| { | ||
| const ECDH = crypto.ECDH; | ||
| const dh = ECDH('prime256v1'); |
There was a problem hiding this comment.
Nit: how about changing the variable name to ecdh?
There was a problem hiding this comment.
Thank you for your review.
I fixed variable names.
DiffieHellmanGroup -> dhg ECDH -> ecdh
cjihrig
approved these changes
Dec 18, 2017
maclover7
approved these changes
Dec 21, 2017
|
Landing... |
|
Thank you for your contribution, landed in 410ce21. |
maclover7
pushed a commit
to maclover7/node
that referenced
this pull request
Dec 21, 2017
PR-URL: nodejs#17728 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
PR-URL: #17728 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
PR-URL: #17728 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
PR-URL: #17728 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added these tests
Current coverage is here: https://coverage.nodejs.org/coverage-1fa59b4c7e575ca7/root/internal/crypto/diffiehellman.js.html
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test