Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: value choice for imitating the old behavior of http.Server.keepAliveTimeout #17660

Closed
wants to merge 2 commits into from
Closed

doc: value choice for imitating the old behavior of http.Server.keepAliveTimeout #17660

wants to merge 2 commits into from

Commits on Dec 14, 2017

  1. doc: value choice for imitating the old behavior of http.Server.keepA… 

    …liveTimeout

Documenting the best way to imitate the old behavior saves time for people
migrating from older versions.
(E.g. for unexpected ECONNRESET)

It isn't immediately obvious if earlier nodejs versions behaved the same
way as nodejs 8 does with keepAliveTimeout = 0.
From 0aa7ef5, it seems like they behave
the same way.

Related to issues such as #13391 that show up when migrating to node 8
    @TysonAndre-tmg @TysonAndre
    TysonAndre-tmg authored and TysonAndre committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    ed9287e View commit details
    Browse the repository at this point in the history

  2. Mention the specific version where keepAliveTimeout was introduced

    @TysonAndre
    TysonAndre committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    3391923 View commit details
    Browse the repository at this point in the history