doc,test: mention Duplex support for TLS #17599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document and test the existing support for generic Duplex streams in the TLS module.
addaleax
added
doc
nodejs-github-bot
added
doc
addaleax
commented
Dec 11, 2017
| assert.strictEqual(serverTLS.read().toString(), 'foobar'); | ||
| assert.strictEqual(clientTLS._handle.writeQueueSize, 0); | ||
| })); | ||
| assert.ok(clientTLS._handle.writeQueueSize > 0); |
There was a problem hiding this comment.
@apapirovski I can remove these checks if you think they’ll conflict with your work?
Just seemed like a nice check to verify that #17564 doesn’t change this behavior :)
There was a problem hiding this comment.
This should work just fine, I believe. Will confirm as soon as I've got something actually working... :)
Trott
approved these changes
Dec 11, 2017
BridgeAR
approved these changes
Dec 11, 2017
cjihrig
approved these changes
Dec 11, 2017
addaleax
added
the
author ready
lpinca
approved these changes
Dec 12, 2017
|
Landed in 93656f4 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Dec 12, 2017
Document and test the existing support for generic Duplex streams in the TLS module. PR-URL: nodejs#17599 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2017
Document and test the existing support for generic Duplex streams in the TLS module. PR-URL: #17599 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2017
Document and test the existing support for generic Duplex streams in the TLS module. PR-URL: #17599 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
|
Is this applicable to v6 or v8? |
|
@MylesBorins Yup, this can safely land in both. |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
Document and test the existing support for generic Duplex streams in the TLS module. PR-URL: #17599 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
Document and test the existing support for generic Duplex streams in the TLS module. PR-URL: #17599 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document and test the existing support for generic Duplex streams in the TLS module.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tls