Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in CONTRIBUTING.md #1755

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in CONTRIBUTING.md #1755

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 21, 2015

Fix minor typographical errors

@brendanashworth brendanashworth added the doc Issues and PRs related to the documentations. label May 21, 2015
@evanlucas
Copy link
Contributor

LGTM

@ChALkeR
Copy link
Member

ChALkeR commented May 21, 2015

I would phrase that as

In case of doubt, open an issue in the issue tracker or contact one of the project Collaborators (IRC is often the best medium). Especially do so if you plan to work on something big. Nothing is more frustrating than seeing your hard work go to waste because your vision does not align with the project team.

But I am not a native English speaker and can't vote, it's just that .) looks weird to me.

@Fishrock123
Copy link
Contributor

@ChALkeR The period inside the parenthesis is technically correct if the parenthesized text isn't part of a prior sentence, or so I have been taught.

@ChALkeR
Copy link
Member

ChALkeR commented May 21, 2015

@Fishrock123 True. But is that really the way how that is usually written? I mean the choice between «Aaaa. (Bbbb.)» and «Aaaa (bbbb).» wording.

Edit: Ok, nevermind. Just forget that, it's not important ☺.

@silverwind
Copy link
Contributor

Have to admit, a dot inside a parens looks weird to me too.

@Trott
Copy link
Member Author

Trott commented May 22, 2015

I'm afraid there's no wiggle room on where to put the period unless the content is reworded. This is the iron-clad direction of every major style guide for written English. (Er, well, the style guides I cite below are for US English, so it's possible that the rules are different in UK et al.)

Fishrock123 pushed a commit that referenced this pull request May 22, 2015
PR-URL: #1755
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Fishrock123
Copy link
Contributor

Thanks, landed in 2bb2f06

@rvagg rvagg mentioned this pull request May 23, 2015
@Trott Trott deleted the typo branch January 29, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants