-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Use common.expectsError in tests #17497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the commit message should start with the test
subsystem.
@mithunsasidharan FWIW, feel free to just open one big pull request if you're doing this for the rest of the tests. It will make it easier to land it and it's really not that hard to review, even if it's 100+ files. (Less to keep track of for backports too.) |
Also, be prepared to backport all of these PRs to other release lines. |
Landed in acd4277 |
PR-URL: #17497 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #17497 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #17497 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Refactored tests to replace
assert.throws(fn, common.expectsError(err));
withcommon.expectsError(fn, err);
in following test files :Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test