fs: ES6 Spread Operator for extended parameter handling #17486
Conversation
nodejs-github-bot
added
the
fs
|
These sort of changes need benchmarks - have you tried running the benchmarks and getting results? |
|
@apapirovski : Thanks for the feedback. I'll close the PR. |
|
@apapirovski would still love some benchmarks |
|
@benjamingr I'm speaking from experience after trying to make this change on |
|
@apapirovski : Thanks for sharing that. Quite helpful 👍 |
|
@apapirovski can you send me a link to those benchmarks then? This is the third time we've been talking about whether or not spread is optimized or not and I want something concrete to go with when I bug V8 people about it :) |
|
@benjamingr the benchmarks are just the events ones... I think I saw the issue when working on |
|
I wish I had more info, it's just that I've been working on that stuff on-and-off for the past 2 months so it's a bit hard to recall at what point I encountered it. You could look over recent events, timers & process PRs potentially. |
|
@apapirovski @benjamingr : Just to mention, post closing the PR.. over my conversation with few JS experienced dev folks.. they did acknowledge too that |
|
ping @bmeurer any thoughts on |
|
FWIW I think the fastest combination here might be When I test that version within @mithunsasidharan If you would like to try that version of the PR and run the relevant benchmarks in Here's the bench results after a short run: Reasonably certain it's faster. Don't think it can land on v8.x or older though. |
|
Also, you could potentially test |
|
@apapirovski : Can you take a look at updated change here ? |
lib/fs.js
Outdated
| @@ -145,8 +145,8 @@ function makeCallback(cb) { | |||
| throw new errors.TypeError('ERR_INVALID_CALLBACK'); | |||
| } | |||
|
|
|||
| return function() { | |||
| return cb.apply(undefined, arguments); | |||
| return function(...arguments) { | |||
There was a problem hiding this comment.
This should be ...args to match the variable below.
There was a problem hiding this comment.
@apapirovski : my bad.. will fix that !
lib/fs.js
Outdated
| return function() { | ||
| return cb.apply(undefined, arguments); | ||
| return function(...arguments) { | ||
| return cb.apply(undefined, args); |
There was a problem hiding this comment.
On that note, could we change this to Reflect.apply(cb, undefined, args);? Thank you! That will mean we no longer depend on the user provided apply.
There was a problem hiding this comment.
@apapirovski : Please take a look now. Thanks !
|
@apapirovski Yes I also think |
|
@apapirovski : Thanks much ! |
|
LGTM |
|
Landed in 0a0fbd5 |
PR-URL: #17486 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
PR-URL: #17486 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
PR-URL: #17486 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Replaced
f.apply(undefined, arguments)to ES 6f(...arguments)Extended Parameter Handling Spread Operator inlib/fs.jsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
fs